search

sevntu-checkstyle / dsm-maven-plugin

Maven plugin to create HTML report to show dependecies in DSM view.
14 stars 5 forks source link

Yuriy #22

Closed balakhonov closed 10 years ago

balakhonov commented 10 years ago

Dsm functionality extended. The cells in which shows cycles are representing as links. 1

Following the link you can see new matrix that represents dependencies between classes in analyzed packages. 2

romani commented 10 years ago

sorry for delay.

never send me in PR changes are not related to each other. By problem in one commit you stop all other changes.

Problems: 1) Why version bump for plugin was done twice ?

2) move "Dsm functionality extended. Now you can see dependencies … " commit to separate PR. It is independent feature, all other changes are ok for me.

3) "Dsm functionality extended....." I completely against this functionality. When you point mouse over "9C" and click you expect to see details of cycling between packages - but you open details of on package and dependencies inside it - and there are no dependencies !!!! if you want to show details of conflicts - you need to create matrix for all classes in that two packages and show dependencies between their classes only.

4) "Update README.md" it is ok, but we will not keep that version always up to date.