search

sevntu-checkstyle / dsm-maven-plugin

Maven plugin to create HTML report to show dependecies in DSM view.
14 stars 5 forks source link

incorrect circle detection between util classes #39

Open romani opened 6 years ago

romani commented 6 years ago

based on 2.2.0 release.

I tested it on checkstyle project, it works, report is generated. But looks like there is problem in DSM matric content generation, some cycles I do not see in code, but this is completely different issue. image https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtils.java https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtils.java

steps to reproduce:

git clone git@github.com:checkstyle/checkstyle.git
mvn site -Pno-validations
# look at generated report.
romani commented 6 years ago

@jimbethancourt , I will add plugin to chekcstyle project as soon as 2.2.0 appear on maven.

Can you help us to validate plugin on correctness of work ? Plugin just render HTML base on dtangler domain object, so it hightly likely that dtangler UI will show the same. Are you interested in maven plugin development ?

jimbethancourt commented 6 years ago

Hi @romani , I am interested in helping, but I'm not sure when I will be able to dedicate enough time to make a lot of headway as this is a side project for me. I agree that the dtangler UI and the dsm plugin will produce the same results and that dtangler's correctness would need to be addressed.

Thanks, Jim

romani commented 6 years ago

Whenever you have a time. We all do open source on the side

romani commented 6 years ago

dsm report is back to web - http://checkstyle.sourceforge.net/dsm/index.html