1)
please remove SimpleModuleFactory, I do not see its usage. If it is required please make a comment - it is not obvious.
2)
MethodCallDependencyModule
it took me a while to understand why it is a Module. Please rename to "xxxxxxxxxxxCheckstyleModule".
You already have a lot of classes not related to Checkstyle, so we need to make it obvious.
3)
mcdc.addAttribute("screenLinesCount", "50");
please add description of this parameter to javadoc.
4)
final DefaultConfiguration mcdc
please name it final moduleConfig
5)
generates violations of method ordering.
you just do reporting of ordering , not a violations. We did not do Check yet, as we do not know rules for now that should be enforced over code.
6)
ReportingCli
rename to ReportCli , "ing" form should be avoided in naming .
ReportingCli
1) please remove SimpleModuleFactory, I do not see its usage. If it is required please make a comment - it is not obvious.
2)
it took me a while to understand why it is a Module. Please rename to "xxxxxxxxxxxCheckstyleModule". You already have a lot of classes not related to Checkstyle, so we need to make it obvious.
3)
please add description of this parameter to javadoc.
4)
please name it final
moduleConfig5)
you just do reporting of ordering , not a violations. We did not do Check yet, as we do not know rules for now that should be enforced over code.
6)
rename to ReportCli , "ing" form should be avoided in naming .