sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

Code review: Main #24

Closed romani closed 8 years ago

romani commented 8 years ago

1)

Collections.singletonMap("screenLinesCount", "50");

to javadoc

2)

final DependencyInformationSerializer consumer

fix the name of variable

3)

         final MethodCallDependencyCheckInvoker invoker =
            new MethodCallDependencyCheckInvoker(attributes, consumer);
consumer.setConfig(invoker.getConfiguration());

cycle of dependency, not good.

4)

public void accept( MethodCallDependencyModule check,

we do not use that parameter, ..... bad design smell . we need to think twice here.

5) Please add ability to generate dot and dsm files base on CLI arguments "--generate-dsm", "--generate-dot". User most likely use only one model that see appropriate for his task.