search

sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

Code review: part 4 #25

Closed romani closed 8 years ago

romani commented 8 years ago 
$ tree
.
├── common
│   ├── DependencyInformationConsumerInjector.java
│   └── MethodCallDependencyCheckInvoker.java
├── domain
│   ├── AnalysisUtils.java
│   ├── ClassDefinition.java
│   ├── Dependencies.java
│   ├── MethodCall.java
│   ├── MethodDefinitionBuilder.java
│   ├── MethodDefinition.java
│   ├── RefCall.java
│   └── ResolvedCall.java
├── dot
│   ├── DependencyInfoGraphSerializer.java
│   └── domain
│       ├── AttributeHolder.java
│       ├── Cluster.java
│       ├── Colors.java
│       ├── Comment.java
│       ├── CompositeElement.java
│       ├── Edge.java
│       ├── Element.java
│       ├── Graph.java
│       ├── Node.java
│       ├── Rankdirs.java
│       └── Shapes.java
├── dsm
│   └── DependencyInfoMatrixSerializer.java
├── Main.java
├── module
│   ├── DependencyInformationConsumer.java
│   ├── MethodCallDependencyModule.java
│   └── ViolationReporterDependencyInformationConsumer.java
├── ordering
│   ├── MethodInvocation.java
│   ├── Method.java
│   ├── Ordering.java
│   └── PenaltyCalculator.java
├── reordering
│   ├── MethodReorderer.java
│   └── TopologicalMethodReorderer.java
├── ReorderingCli.java
├── ReportingCli.java
└── utils
    ├── FileUtils.java
    └── UnexpectedTokenTypeException.java

1) AnalysisUtils, MethodDefinitionBuilder are located in domain package. Domain package is better to be POJO classes. can we move that files outside of this package ?

2) Rankdirs.java hmmm, can write javadoc , it is not clear a reason of this class.

3) ResolvedCall vs RefCall - please specify a difference

4) ordering and reordering packages. looks like first is domain and second is actual logic. does it make sense to be like : 

ordering
  +--domain

5) UnexpectedTokenTypeException it is not utils. It is used not only in Utils, so it belong to "common" to my mind.