search

sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

Implemented proper handling of absent files. Fixes #34 #35

Closed alex-zuy closed 7 years ago

alex-zuy commented 7 years ago

please review

romani commented 7 years ago

It is not ok. You will never write logic for all problems that could happen with files. Checker or Treewalker or Module should fail with exception , all you need it to deliver it to user

alex-zuy commented 7 years ago

You are absolutely correct, but Checker violates this principle (it catches IOException and logs it without rethrowing, wrapping, etc). That's what forced me to check file existence manually. Look's like Checker need to be fixed in order fix issue #34 correctly.

romani commented 7 years ago

Please use fileMessages , it is not only logged.

alex-zuy commented 7 years ago

@romani , please review