search

sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

Analysis misses some dependencies #55

Closed wilcoln closed 4 years ago

wilcoln commented 4 years ago

This problem was discovered in conversation for PR https://github.com/checkstyle/checkstyle/pull/7960, which is about optimizing the methods distance in checkstyle.api.FileText class.

A quick look at that class shows us that public int size() is used in findLineBreaks(), but for some reason analysis does not capture that dependency.

To visualize this yourself, checkout the provided dsm report.

romani commented 4 years ago

PR to fix problem is welcome.

romani commented 4 years ago

Fix is merged