search

sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

minor: remove redundant this (Issue checkstyle#7895) #66

Closed Rahulkhinchi03 closed 2 years ago

Rahulkhinchi03 commented 2 years ago

major: (https://github.com/checkstyle/checkstyle/pull/11053)

Rahulkhinchi03 commented 2 years ago

@rnveach Kindly review my changes!

rnveach commented 2 years ago

@romani I assume you agree with these changes since they follow the similar setup to RequireThis? Issue is not approved so making double sure.

rnveach commented 2 years ago

@Rahulkhinchi03 I did not notice this, but commit message has to change. There is no issue 7895 in this repo.

I would use something like: minor: remove redundant this (Issue checkstyle#7895).

rnveach commented 2 years ago

@Rahulkhinchi03 Just so it is clear, Issue title != Commit message.

Rahulkhinchi03 commented 2 years ago

I will keep this in mind, thanks @rnveach!

romani commented 2 years ago

checkstyle issue is approved.