search

sevntu-checkstyle / methods-distance

GNU Lesser General Public License v3.0
5 stars 13 forks source link

infra: migrate to CircleCI #74

Closed nrmancuso closed 1 year ago

nrmancuso commented 1 year ago

Completes migration to CircleCI

We need HEROKU_API_KEY stored in env variables in project settings, see https://circleci.com/developer/orbs/orb/circleci/heroku for details

nrmancuso commented 1 year ago

@romani are you good if I test heroku deploy via this branch?

romani commented 1 year ago

Better to do this by GitHub action from master, more secure

romani commented 1 year ago

Or maybe be circleci have manual trigger from ui?

nrmancuso commented 1 year ago

Right now, this workflow will only run on merge to master, which is what travis was doing before. Also - I did not turn on building forked PRs for this repo. So we should be fine security-wise. We can make this workflow able to be triggered by UI only though, if you want.

romani commented 1 year ago

We can make this workflow able to be triggered by UI only though, if you want.

@nrmancuso , it would be awesome. better to release when required, not on commit, as some commits are not functional changes for user.