Open stoyanK7 opened 1 year ago
I think it is reasonable to add such tags to property setters anywhere really, let's see what others think.
I don't believe this repo has those things documented, so it will be regression hunting to identify all the versions to add. The custom branch I used referenced in the main repo's issue should be able to be used for this.
I am fine with this being done.
This repo don't need this metadata for now, if we have time in future we will do this
In https://github.com/checkstyle/checkstyle/pull/13455 we add a
MatchXPath
check to ensure that all property setters have a@since
property in their Javadoc. For exampleIn https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/1023 we add a suppression for all checks in this repository because the CI in checkstyle repo is failing https://checkstyle.semaphoreci.com/jobs/b80149c4-f163-4908-a4ab-98a19bcb625e
I am not sure if we want to add those
@since
s in this project or if it's possible. The purpose of this issue is to add anuntil ...
on the line above the suppression of this check and discuss potentially removing it in the future