sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 146 forks source link

Add no-exceptions testing lauches to CI #644

Closed romani closed 6 years ago

romani commented 6 years ago

when new Check is proposed in PR, after code-review almost forgot to request regression testing. At least default execution of check should be done automatically on most our testing projects, as we do this at: https://github.com/checkstyle/checkstyle/blob/master/wercker.yml

the same CIs could be used.

rnveach commented 6 years ago

groovy ./launch.groovy --listOfProjects projects-for-wercker.properties \ --config checks-nonjavadoc-error.xml --checkstyleVersion ${CS_POM_VERSION}

Groovy scripts don't support sevntuVersion.

https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/pom.xml#L16 Default maven configuration uses release version, not snapshot version. https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/pom.xml#L15 Default maven configuration uses snapshot version for checkstyle.

We need to be able to override both values.

romani commented 6 years ago

Fix is merged