search

sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 146 forks source link

Issue #847: Support assertWithMessage(...).fail() #848

Closed pbludov closed 3 years ago

pbludov commented 3 years ago

Issue #847

This is blocker for checkstyle/checkstyle#9142.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.003%) to 98.782% when pulling a3cbe9c5278b09e288ded81348c08e132f44b0cf on pbludov:issue-847-assert-with-message-fail into 614f15bf59ad8d1ac5fa3e5d7f8bc1828ada5918 on sevntu-checkstyle:master.

rnveach commented 3 years ago

Sevntu regression on an existing check is only possible with https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/sevntu_launch_diff.sh . See https://github.com/checkstyle/contribution/issues/340 .

pbludov commented 3 years ago

@pbludov , please run regression report generation to amke sure there is no regression.

Done: https://pbludov.github.io/issue-847-assert-with-message-fail/