search

sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 146 forks source link

Replace usage of CheckUtil#createFullType with FullIdent#createFullIdent because it was removed in checkstyle 9.2 #876

Closed nrmancuso closed 2 years ago

nrmancuso commented 2 years ago

Related to changes at https://github.com/checkstyle/checkstyle/pull/10839/commits/7462b00c2f0d470be6d3d8825f83c717cc5696aa, and noticed in check regression testing for https://github.com/checkstyle/checkstyle/pull/10979, we need to replace usages of CheckUtil#createFullType with FullIdent#createFullIdent now that CheckUtil#createFullType has been removed.

It breaking compatibility with main library. New versions of sevntu can not work with checkstyle versions below 9.2 due to https://github.com/checkstyle/checkstyle/issues/10144

Sevntu Checkstyle Release 1.40.0 compatible with checkstyle up to checkstyle 9.1 . Sevntu Checkstyle Release 1.41.0 will be compatible with all recent checkstyle versions.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 98.796% when pulling 873bcb6363a38296ad589e0e39f7c0d377f848c4 on nmancus1:checkstyle-fullident into 97623a0fcee8e2dea2ae9fe7320eb7c890bcb638 on sevntu-checkstyle:master.

romani commented 2 years ago

From this project perspective this is not a minor. It breaking compatibility with main library. New versions of sevntu can not work with checkstyle versions below 9.2 due to https://github.com/checkstyle/checkstyle/issues/10144

Let's update commit with this context or use "pull #xxxx" prefix to let be printed in release notes of sevntu