search

sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 147 forks source link

Issue #883: upgrade minimal required jdk version to 11 #884

Closed pbludov closed 2 years ago

pbludov commented 2 years ago

Issue #883

Some Guava code replaced with JDK alternatives.

romani commented 2 years ago

I think we need to bind this update to bump of plugins to 10.x version.

rnveach commented 2 years ago

~@pbludov it seems to me we can continue with this if eclipse-cs' bump is in maven.~ EDIT: My bad, eclipse-cs has not even made the necessary changes. For some reason I thought they did.

rnveach commented 2 years ago

Eclipse-cs now upgraded. https://github.com/checkstyle/eclipse-cs/releases/tag/10.0.0

romani commented 2 years ago

elipse-cs compilation is failing:

[WARNING] No explicit target runtime environment configuration. Build is platform dependent.
[INFO] Computing target platform for MavenProject: com.github.sevntu-checkstyle:eclipsecs-sevntu-plugin:1.41.0 @ /home/rivanov/java/github/sevntu-checkstyle/sevntu.checkstyle/eclipsecs-sevntu-plugin/pom.xml
[INFO] Fetching p2.index from http://download.eclipse.org/releases/juno/ (0B of 128B at 0B/s)
[INFO] Adding repository http://download.eclipse.org/releases/juno
[INFO] Fetching p2.index from http://download.eclipse.org/releases/juno/201303010900/ (0B of 365B at 0B/s)
[INFO] Fetching p2.index from http://download.eclipse.org/releases/juno/201209280900/ (0B of 365B at 0B/s)
[INFO] Fetching p2.index from http://download.eclipse.org/releases/juno/201206270900/ (0B of 365B at 0B/s)
[INFO] Fetching p2.index from http://download.eclipse.org/technology/epp/packages/juno/ (0B of 116B at 0B/s)
[INFO] Resolving dependencies of MavenProject: com.github.sevntu-checkstyle:eclipsecs-sevntu-plugin:1.41.0 @ /home/rivanov/java/github/sevntu-checkstyle/sevntu.checkstyle/eclipsecs-sevntu-plugin/pom.xml
[WARNING] The following locally built units have been used to resolve project dependencies:
[WARNING]   eclipsecs-sevntu-plugin/1.41.0
[WARNING]   net.sf.eclipsecs.checkstyle/10.0.0.202205012130
[WARNING]   net.sf.eclipsecs.core/10.0.0.202205012130
[WARNING]   net.sf.eclipsecs.ui/10.0.0.202205012130
[INFO] Resolving class path of MavenProject: com.github.sevntu-checkstyle:eclipsecs-sevntu-plugin:1.41.0 @ /home/rivanov/java/github/sevntu-checkstyle/sevntu.checkstyle/eclipsecs-sevntu-plugin/pom.xml
[ERROR] Internal error: org.eclipse.tycho.core.osgitools.OsgiManifestParserException: Exception parsing OSGi MANIFEST /home/rivanov/.m2/repository/net/sf/eclipsecs/net.sf.eclipsecs.checkstyle/10.0.0-SNAPSHOT/net.sf.eclipsecs.checkstyle-10.0.0-SNAPSHOT.jar!/META-INF/MANIFEST.MF: Unknown OSGi execution environment: 'JavaSE-11' -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: org.eclipse.tycho.core.osgitools.OsgiManifestParserException: Exception parsing OSGi MANIFEST /home/rivanov/.m2/repository/net/sf/eclipsecs/net.sf.eclipsecs.checkstyle/10.0.0-SNAPSHOT/net.sf.eclipsecs.checkstyle-10.0.0-SNAPSHOT.jar!/META-INF/MANIFEST.MF: Unknown OSGi execution environment: 'JavaSE-11'
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.eclipse.tycho.core.osgitools.OsgiManifestParserException: Exception parsing OSGi MANIFEST /home/rivanov/.m2/repository/net/sf/eclipsecs/net.sf.eclipsecs.checkstyle/10.0.0-SNAPSHOT/net.sf.eclipsecs.checkstyle-10.0.0-SNAPSHOT.jar!/META-INF/MANIFEST.MF: Unknown OSGi execution environment: 'JavaSE-11'
    at org.eclipse.tycho.core.osgitools.OsgiManifest.parseExecutionEnvironments (OsgiManifest.java:69)
    at org.eclipse.tycho.core.osgitools.OsgiManifest.<init> (OsgiManifest.java:55)
    at org.eclipse.tycho.core.osgitools.OsgiManifest.parse (OsgiManifest.java:152)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.loadManifestFromFile (DefaultBundleReader.java:82)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.doLoadManifest (DefaultBundleReader.java:60)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.loadManifest (DefaultBundleReader.java:49)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.loadManifest (EquinoxResolver.java:248)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.newState (EquinoxResolver.java:158)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.newResolvedState (EquinoxResolver.java:67)
    at org.eclipse.tycho.core.osgitools.OsgiBundleProject.getResolverState (OsgiBundleProject.java:252)
    at org.eclipse.tycho.core.osgitools.OsgiBundleProject.resolveClassPath (OsgiBundleProject.java:155)
    at org.eclipse.tycho.core.resolver.DefaultTychoResolver.resolveProject (DefaultTychoResolver.java:120)
    at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead (TychoMavenLifecycleParticipant.java:75)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.eclipse.tycho.core.ee.UnknownEnvironmentException: Unknown OSGi execution environment: 'JavaSE-11'
    at org.eclipse.tycho.core.ee.ExecutionEnvironmentUtils.getExecutionEnvironment (ExecutionEnvironmentUtils.java:87)
    at org.eclipse.tycho.core.osgitools.OsgiManifest.parseExecutionEnvironments (OsgiManifest.java:66)
    at org.eclipse.tycho.core.osgitools.OsgiManifest.<init> (OsgiManifest.java:55)
    at org.eclipse.tycho.core.osgitools.OsgiManifest.parse (OsgiManifest.java:152)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.loadManifestFromFile (DefaultBundleReader.java:82)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.doLoadManifest (DefaultBundleReader.java:60)
    at org.eclipse.tycho.core.osgitools.DefaultBundleReader.loadManifest (DefaultBundleReader.java:49)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.loadManifest (EquinoxResolver.java:248)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.newState (EquinoxResolver.java:158)
    at org.eclipse.tycho.core.osgitools.EquinoxResolver.newResolvedState (EquinoxResolver.java:67)
    at org.eclipse.tycho.core.osgitools.OsgiBundleProject.getResolverState (OsgiBundleProject.java:252)
    at org.eclipse.tycho.core.osgitools.OsgiBundleProject.resolveClassPath (OsgiBundleProject.java:155)
    at org.eclipse.tycho.core.resolver.DefaultTychoResolver.resolveProject (DefaultTychoResolver.java:120)
    at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead (TychoMavenLifecycleParticipant.java:75)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR]

Solution: https://www.codetd.com/en/article/13854167

diff --git a/eclipse-pom.xml b/eclipse-pom.xml
index 76a5f1b..f5694ec 100644
--- a/eclipse-pom.xml
+++ b/eclipse-pom.xml
@@ -22,7 +22,7 @@
   </modules>

   <properties>
-    <tycho-version>0.21.0</tycho-version>
+    <tycho-version>1.3.0</tycho-version>
   </properties>

   <repositories>