sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 147 forks source link

config: upgrade eclipsecs-sevntu-plugin to 10.4 #941

Closed rnveach closed 1 year ago

rnveach commented 1 year ago

I did a search and did not find any other 10.0.

rnveach commented 1 year ago

The issue can be seen in master at https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/588778843 starting with https://github.com/sevntu-checkstyle/sevntu.checkstyle/commit/45ae6b1c4012b6f9139419e3053856ca3298bb20 (11 days ago)

Previous build passed which was updating the checkstyle version at https://github.com/sevntu-checkstyle/sevntu.checkstyle/commit/83a2bce0e10b0b77c462dc02cf56be25376d50b7 (13 days ago)

https://github.com/checkstyle/eclipse-cs/tags eclipse-cs released 10.4 (13 days ago) eclipse-cs released 10.3.4 (14 days ago)

https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/931#issuecomment-1315943475 Sevntu cache was cleared somewhere around that time. I did not make a post about it.

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 98.798% when pulling 6ebe5621fa3c73637020e2ee1e1a156ceb27ec8a on rnveach:fix_eclipsecs_sevntu into e0e2035e2f79e4bfad8502b5f2b7cc84eed95299 on sevntu-checkstyle:master.

rnveach commented 1 year ago

I am not seeing how CI did not report the issue during the upgrade, but only after. It is possible it was a cache issue, but I am unsure.