search

sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 147 forks source link

infra: fails build if checkstyle versions don't match with eclipse-cs #942

Closed rnveach closed 1 year ago

rnveach commented 1 year ago

After looking at https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/941#issuecomment-1329429741 and options, we cannot combine POMs because eclipse-cs is not in maven, this is why we always have to install it before hand.

Instead, this change will manually verify checkstyle versions match up between different POMs. Fixed the first one where the main issue was identified.

This should fail without the referenced PR merged and should pass afterwards.

rnveach commented 1 year ago

https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/589652909#L422 There is no message, but CI failed as expected where expected. Pushed an update to see if I can get the message to display.

CI should pass when https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/941 is merged

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 98.798% when pulling 224647fad8b3ae00f8ae94449b566918f8e49757 on rnveach:eclipsecs_version_matcher into e0e2035e2f79e4bfad8502b5f2b7cc84eed95299 on sevntu-checkstyle:master.

rnveach commented 1 year ago

This won't work anyways. I am trying to pull in the verify time Checkstyle. They embed their JAR into the project, so I would need to verify a file name or something.