fix: identify reply of command `bgsave` uncorrectly.

sewenew / redis-plus-plus

Redis client written in C++

Apache License 2.0

1.6k stars 347 forks source link

fix: identify reply of command `bgsave` uncorrectly. #462

Closed ShuYuMo2003 closed 1 year ago

ShuYuMo2003 commented 1 year ago

The normal reply message of command bgsave should be 'Background saving started' but not 'OK'.

sewenew commented 1 year ago

Thanks for finding the bug!

However, since bgsave does not return "OK", we should not parse the reply as void. Instead, I think we'd better modify the interface to make it return std::string. Check the return type doc for more explanation.

Could you please modify your PR to change the bgsave interface? Thanks again!

Regards

ShuYuMo2003 commented 1 year ago

I am sorry. I do not famaliar with redis protocol. I will study and modify it soon. Please wait.

sewenew commented 1 year ago

Thanks a lot for your contribution!

Regards