sewenew / redis-plus-plus

Redis client written in C++
Apache License 2.0
1.64k stars 351 forks source link

[BUG] XADD command does not take stream id input as "<timestamp>-*" #463

Closed ajitbansal closed 1 year ago

ajitbansal commented 1 year ago

Describe the bug When calling XADD from redis-client xadd(key, "1679330828564-*" foo bar) not able to see the key in redis server.

But calling xadd(key, "*", foo bar) able to see the key in redis server.

To Reproduce calculate timestamp in milliseconds and add it to the string as "-*"

Expected behavior An entry should be done in redis server

Environment:

Additional context according to https://redis.io/commands/xadd/ calling XADd with stream id "-*" should work

sewenew commented 1 year ago

redis-plus-plus doesn’t do special operations on the id field, instead, it sends the string you passed.

If you cannot use timestamp-* form, it should be that your Redis server doesn’t support it. Since this is a new feature of Redis 7.0, if your Redis is older than 7.0, you cannot send id with this form. Please check your Redis version.

Regards


发件人: ajitbansal @.> 发送时间: Tuesday, March 21, 2023 12:56:03 AM 收件人: sewenew/redis-plus-plus @.> 抄送: Subscribed @.**> 主题: [sewenew/redis-plus-plus] [BUG] XADD command does not take stream id input as "-" (Issue #463)

Describe the bug When calling XADD from redis-client xadd(key, "1679330828564-*" foo bar) not able to see the key in redis server.

But calling xadd(key, "*", foo bar) able to see the key in redis server.

To Reproduce calculate timestamp in milliseconds and add it to the string as "-*"

Expected behavior An entry should be done in redis server

Environment:

Additional context according to https://redis.io/commands/xadd/ calling XADd with stream id "-*" should work

― Reply to this email directly, view it on GitHubhttps://github.com/sewenew/redis-plus-plus/issues/463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWWTAJPRAK7DLYNYDMUBR3W5CD2HANCNFSM6AAAAAAWBLKLIE. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ajitbansal commented 1 year ago

Thanks for the response sewenew. I will close this issue. BTW this redis client(redis-plus-plus) is really awesome product :) you really are unsung hero

sewenew commented 1 year ago

Thanks for choosing redis-plus-plus! If it's helpful, feel free to spread it and star it :)

Regards