[BUG] redis++.pc.in not set to respect CMake_install_lib

sewenew / redis-plus-plus

Redis client written in C++

Apache License 2.0

1.64k stars 351 forks source link

[BUG] redis++.pc.in not set to respect CMake_install_lib #474

Closed jrwrigh closed 1 year ago

jrwrigh commented 1 year ago

Describe the bug It's possible that the redis++.pc that is created at compile time has the wrong libdir entry, as CMake can change the install location of the library. I believe this can be fixed by using

libdir=${exec_prefix}/@CMAKE_INSTALL_LIBDIR@

in cmake/redis++.pc.in.

In my situtation, it's installed in lib64 instead of lib.

sewenew commented 1 year ago

Fixed. Please test it with the latest code on master branch. Thanks for pointing it out!

Regards

jrwrigh commented 1 year ago

I've confirmed that fixed the issue. Thanks!

jrwrigh commented 1 year ago

Also, it'd be nice if you could release a patch fix with this fix on it. I originally ran into this issue using https://github.com/CrayLabs/SmartRedis, but I doubt they'd want to update their installer/supported version without an official release.

sewenew commented 1 year ago

Already published a new release. Enjoy it :)

Regards

jrwrigh commented 1 year ago

Thanks!