search

sewenew / redis-plus-plus

Redis client written in C++
Apache License 2.0
1.6k stars 347 forks source link

Fix a static analysis warning #590

Closed TedLyngmo closed 2 weeks ago

TedLyngmo commented 3 weeks ago

reply.h: std::move was used where std::forward should be used

Fixes #589

TedLyngmo commented 3 weeks ago

The failure to build on Windows seems unrelated to this patch:

CMake Error at test/CMakeLists.txt:10 (find_path):
  Could not find HIREDIS_HEADER using the following files: hiredis
sewenew commented 2 weeks ago

Thanks for your contributing!

Could you revert the noexcept change, and I'll merge your PR.

Thanks again!

sewenew commented 2 weeks ago

The failure to build on Windows seems unrelated to this patch:

CMake Error at test/CMakeLists.txt:10 (find_path):
  Could not find HIREDIS_HEADER using the following files: hiredis

Yes. The Windows build failure has nothing to do with your PR.