search

sewpafly / post-thumbnail-editor

Wordpress Plugin to manually edit post thumbnails
http://wordpress.org/extend/plugins/post-thumbnail-editor/
32 stars 18 forks source link

Gif support #116

Open TMcLoone opened 9 years ago

TMcLoone commented 9 years ago

Hey I'm wondering if there's any way you can support gifs (when they get added they get cut and only one frame shows) or if there's a way to tell it to ignore gifs completely?

sewpafly commented 9 years ago

I'm guessing you mean animated gifs -- I should be able to put an exception in the code to ignore those that are animated. I'll look into it.

TMcLoone commented 9 years ago

Yes sorry, animated gifs.

Thanks so much Brent!

On Jul 15, 2015, at 16:33, Brent notifications@github.com wrote:

I'm guessing you mean animated gifs -- I should be able to put an exception in the code to ignore those that are animated. I'll look into it.

— Reply to this email directly or view it on GitHub https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121757030.

sewpafly commented 9 years ago

http://php.net/manual/en/imagick.getimageiterations.php http://it.php.net/manual/en/function.imagecreatefromgif.php#59787

TMcLoone commented 9 years ago

cool, where should I put this in the php? (sorry, new to wordpress and php here).

On Jul 15, 2015, at 16:38, Brent notifications@github.com wrote:

http://php.net/manual/en/imagick.getimageiterations.php http://php.net/manual/en/imagick.getimageiterations.php http://it.php.net/manual/en/function.imagecreatefromgif.php#59787 http://it.php.net/manual/en/function.imagecreatefromgif.php#59787 — Reply to this email directly or view it on GitHub https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121757951.

sewpafly commented 9 years ago

Sorry, that was for me (as a note), not for you. :)

On Wed, Jul 15, 2015 at 2:44 PM, Tim McLoone notifications@github.com wrote:

cool, where should I put this in the php? (sorry, new to wordpress and php here).

On Jul 15, 2015, at 16:38, Brent notifications@github.com wrote:

http://php.net/manual/en/imagick.getimageiterations.php < http://php.net/manual/en/imagick.getimageiterations.php> http://it.php.net/manual/en/function.imagecreatefromgif.php#59787 < http://it.php.net/manual/en/function.imagecreatefromgif.php#59787> — Reply to this email directly or view it on GitHub < https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121757951 .

— Reply to this email directly or view it on GitHub https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121759212 .

TMcLoone commented 9 years ago

Ahh no worries. Look forward to seeing it working! We'll shoot you coffee/beers over :)

On Jul 15, 2015, at 17:04, Brent notifications@github.com wrote:

Sorry, that was for me (as a note), not for you. :)

On Wed, Jul 15, 2015 at 2:44 PM, Tim McLoone notifications@github.com wrote:

cool, where should I put this in the php? (sorry, new to wordpress and php here).

On Jul 15, 2015, at 16:38, Brent notifications@github.com wrote:

http://php.net/manual/en/imagick.getimageiterations.php < http://php.net/manual/en/imagick.getimageiterations.php> http://it.php.net/manual/en/function.imagecreatefromgif.php#59787 < http://it.php.net/manual/en/function.imagecreatefromgif.php#59787> — Reply to this email directly or view it on GitHub < https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121757951 .

— Reply to this email directly or view it on GitHub https://github.com/sewpafly/post-thumbnail-editor/issues/116#issuecomment-121759212 .

— Reply to this email directly or view it on GitHub.