search

sewpafly / post-thumbnail-editor

Wordpress Plugin to manually edit post thumbnails
http://wordpress.org/extend/plugins/post-thumbnail-editor/
32 stars 18 forks source link

[feature] Add support for WPML and more plugins. #121

Closed MrKoopie closed 8 years ago

MrKoopie commented 8 years ago

When WPML is installed, it adds ?lang=xx to the output of admin_url. This is not supported by post-thumbnail-editor yet and therefore the page where the image can be cropped fails to load.

This pull request checks if the admin_url() returns a question mark. If it does, an ampersand is used rather than a question mark. This makes the plugin compatible with WPML, but also with other third-party plugins who may add a question mark.

sewpafly commented 8 years ago

Thanks!

MrKoopie commented 8 years ago

@sewpafly when will you release a new version at WordPress? Currently I have installed the code manually in our development environment, however I prefer to install the fix with an update with WordPress in our test environment.

MrKoopie commented 8 years ago

@sewpafly Do you have an update on this? I have implemented the update manually, but prefer to do this via the regular way (the WordPress update system).