search

seydx / homebridge-tado-thermostat

Homebridge plugin for controlling Tado smart thermostats with Fakegato History
MIT License
11 stars 27 forks source link

Zones/accessories might not be correct after inital setup #7

Closed oynek closed 6 years ago

oynek commented 6 years ago

My current tado setup looks like this:

Living room: 1x tado smart radiator thermostat, 1x tado smart wall mounted thermostat bathroom: 1x tado smart radiator thermostat bed room: 1x tado smart radiator thermostat

[2018-3-26 14:01:05] [Thermostat] Home ID is: XXXX                                                          
[2018-3-26 14:01:05] [Thermostat] Getting Temperature Unit...  
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Wohnzimmer 0 (4 | RU01)                                     
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Wohnzimmer 1 (4 | VA01)                                     
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Schlafzimmer 0 (2 | RU01)                                   
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Schlafzimmer 1 (2 | VA01)                                   
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Badezimmer 0 (3 | RU01)                                     
[2018-3-26 14:01:05] [Thermostat] Found new Zone: Badezimmer 1 (3 | VA01)                                     
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Wohnzimmer 0'...                           
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Wohnzimmer 1'...                           
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Schlafzimmer 0'...                         
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Schlafzimmer 1'...                         
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Badezimmer 0'...                           
[2018-3-26 14:01:05] [Thermostat] Initializing platform accessory 'Badezimmer 1'...

In my use case the plugin creates six different homekit accessories (see log). To my understanding this is not correct. As far as i know the wall mounted tado smart thermostat technically controls the heating request for all radiator valves. It collects information about temperature in every room and sends a heating request to the boiler if neccessary. So from a point of software architecture this could be right - but this is not how the offical tado homekit integration works, it just creates four different accessories .

Furthermore I am not sure if the operation mode of my tados is displayed correctly. See my screenshot:

file

seydx commented 6 years ago

I will add a new option in the next version for excluding unnecessary types to fix this problem

seydx commented 6 years ago

v3.2.0 is up to restrict the plugin not to expose more accessory as needed, you can set following option into your config json:

"includeTypes":["VA01", "RU01"]

if nothing setted, both types will be exposed to HomeKit. If you want to expose only i.e. VA01, just remove "RU01" from the array

oynek commented 6 years ago

Pretty good work, sir. Tado developers should look for that.

seydx commented 6 years ago

So it works as intended? Then im closing this issue :)