seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 996 forks source link

Clean out the issues list @seyhunak #557

Closed toadkicker closed 10 years ago

toadkicker commented 11 years ago

We have issues in our list going back pretty far with no activity. I think we should clean them out @seyhunak because it makes the gem look like its broken when its really awesome.

seyhunak commented 11 years ago

@toadkicker yes, you are right, I'll try to catch some time to do this, can you help me out?

toadkicker commented 11 years ago

Sure, I need permissions to close tickets other than my own.

seyhunak commented 11 years ago

@toadkicker ok thanks, added as collaborator

toadkicker commented 11 years ago

Any feedback on labels/milestones? Think we're good on the list for now?

seyhunak commented 11 years ago

@toadkicker currently, i'm about to bump new version with latest updates to Rubygems

seyhunak commented 11 years ago

@toadkicker did you tested the gem on any Rails 4 project?

toadkicker commented 11 years ago

No, didn't think we were ready for that.

On Monday, April 29, 2013, Seyhun Akyürek wrote:

@toadkicker https://github.com/toadkicker did you tested the gem on any Rails 4 project?

— Reply to this email directly or view it on GitHubhttps://github.com/seyhunak/twitter-bootstrap-rails/issues/557#issuecomment-17193041 .

seyhunak commented 11 years ago

@toadkicker what is left to do? So tagged v2.2.7 for current state.

Can you please check? https://github.com/seyhunak/twitter-bootstrap-rails/commits/v2.2.7

Also we need to test it on Rails 4, to then we can go to major update.

toadkicker commented 11 years ago

Will do no problem

On Monday, April 29, 2013, Seyhun Akyürek wrote:

@toadkicker https://github.com/toadkicker what is left to do? So tagged v2.2.7 for current state.

Can you please check? https://github.com/seyhunak/twitter-bootstrap-rails/commits/v2.2.7

Also we need to test it on Rails 4, to then we can go to major update.

— Reply to this email directly or view it on GitHubhttps://github.com/seyhunak/twitter-bootstrap-rails/issues/557#issuecomment-17193462 .

toadkicker commented 11 years ago

screen shot 2013-04-29 at 6 07 58 pm

toadkicker commented 11 years ago
source 'https://rubygems.org'

#gem 'rails', '~>3.2'

# Bundle edge Rails instead:
gem 'rails', :git => 'git://github.com/rails/rails.git', :tag => 'v4.0.0.rc1'

gem 'pg'

# Gems used only for assets and not required
# in production environments by default.
group :assets do
  gem 'sass-rails', :git => 'https://github.com/rails/sass-rails.git', :tag => 'v4.0.0.rc1'
  gem 'coffee-rails', '~> 4.0'
  gem 'less'
  gem 'commonjs'
  gem 'therubyracer', :platforms => :ruby
  gem 'uglifier', '>= 1.0.3'
end
# See https://github.com/sstephenson/execjs#readme for more supported runtimes
gem 'libv8', '~> 3.11.8'
gem 'jquery-rails'
gem 'less-rails'
gem 'twitter-bootstrap-rails', :git => 'git@github.com:seyhunak/twitter-bootstrap-rails.git', :tag => 'v2.2.7'
gem 'formtastic'
gem 'formtastic-bootstrap'

# To use ActiveModel has_secure_password
# gem 'bcrypt-ruby', '~> 3.0.0'

# To use Jbuilder templates for JSON
# gem 'jbuilder'

# Use unicorn as the app server
# gem 'unicorn'

# Deploy with Capistrano
# gem 'capistrano'

# To use debugger
# gem 'debugger'
toadkicker commented 11 years ago

(fwiw I need to grab the new views for 2.3.1 and put them in teststrap)

seyhunak commented 11 years ago

@toadkicker Looks like it works, currently gem includes 2.3.1. Can you please update 2.3.1 views to teststrap?

findchris commented 11 years ago

:+1: For Rails 4 support