seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.49k stars 997 forks source link

Need to declare which version of Bootstrap is used in this package. #690

Closed shuklaneerajdev closed 10 years ago

shuklaneerajdev commented 10 years ago

It seems to be that the version of bootstrap used here is 2.3.2 As a new version of Bootstrap is released and that is what is pointed to by the bootstrap website, people can get confused when they find that the documentation on the bootstrap website does not work for them.

Hence it needs to be shown upfront as to which version of bootstrap we are using.

vgracia commented 10 years ago

Yeah this would have saved me some time. I am currently using the latest version of bootstrap and wanted to see if my code would be compatible with this gem. I could not find which version is supported anywhere but in the issue report above.

shuklaneerajdev commented 10 years ago

Yes. And the version 2.3.2 that I suggested is based on some experiments that I was doing, I am still not sure that this is indeed the version used. Unfortunately I don't know how to find this out. If someone is more aware in this regard, please help us out here. Thanks.

gruntled commented 10 years ago

Extremely confusing. In fact, I cannot get this gem to install Bootstrap 3.1.1 into my rails app. Only BS 2.3.2 code works and all of the .js files are v. 2.3.2. Does anybody know how to get BS 3.1.1 working in a Rails app? I'm using Rails 3.2.16, but it doesn't work in Rails 4 either.

cbstodd commented 10 years ago

I am having the same problems after a clone from Github...

gruntled commented 10 years ago

Well I figured out after my last post that this gem does not work with 3.1.1. I switched to bootstrap-sass and everything is working fine now.

toadkicker commented 10 years ago

Covered in Pull #708 and #709

Bootstrap3 support is in a different branch from master, slated for merge after @seyhunak reviews