search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.49k stars 997 forks source link

Navbar does not work on mobile devices #772

Closed panmari closed 10 years ago

panmari commented 10 years ago

See discussion on Stackoverflow for details.

toadkicker commented 10 years ago

Thanks for pointing this out to us. This will likely be overwritten though when Bootstrap releases 3.2.1, so I hesitate to take this PR because it won't persist and we'll set the expectation it is working for us and not the official release. As with most OSS software built on other projects, their bugs are their bugs, and we can send Bootstrap a PR but we don't deviate in our own library.

I think we're probably better off discussing this in the README.md in a known issues section. Another solution is to add 

$('.dropdown-menu').on('touchstart.dropdown.data-api', (e) ->
    e.stopPropagation() )

to the generated bootstrap.js file. That way we can keep the lib from being patched and stay consistent with known bugs from Bootstrap.