search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 996 forks source link

bootstrap_flash only takes some messages into account #788

Closed phikes closed 10 years ago

phikes commented 10 years ago

Namely the problem is that with Rails 4.1.5 and devise I can't see the alert and notice messages devise passes into flash.

After debugging I found out that devise uses e.g. flash['alert'] instead of flash[:alert] (for which bootstrap_flash checks). The default alert and notice helpers do output messages which are added with string keys so I propose bootstrap_flash should do that, too.

phikes commented 10 years ago

I was a little to fast and overlooked line 10, which converts the typeto a symbol. Nevertheless my devise notifications are not rendered. I will further investigate and report back.

phikes commented 10 years ago

Nevermind I am not using the latest version. My version doesn't have the symbol conversion.