search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 998 forks source link

add type attribute to button for bootstrap flashes #806

Closed tielur closed 9 years ago

tielur commented 9 years ago

According to bootlint all buttons should have a type shown here

This pull request adds the default type="button" to the BootstrapFlashHelper.

References: http://wtfhtmlcss.com/#buttons-type

toadkicker commented 9 years ago

Can you update the test as well? Also we use git flow, so the PR needs to merge into develop please.

tielur commented 9 years ago

Sounds good, I'll add/update tests and open a new pull request against the develop branch.