Add type attribute to button for bootstrap flashes

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline

https://github.com/seyhunak/twitter-bootstrap-rails

4.5k stars 998 forks source link

Add type attribute to button for bootstrap flashes #808

Closed tielur closed 9 years ago

tielur commented 9 years ago

According to bootlint all buttons should have a type shown here

This pull request adds the default type="button" to the BootstrapFlashHelper. I've also added specs for BootstrapFlashHelper. I've tried to follow the format/style of the existing specs.

References: http://wtfhtmlcss.com/#buttons-type

tielur commented 9 years ago

I added specs in reference to #806 but I was still branched off of master. Doh. I'll fix this again, sorry.