search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 998 forks source link

Font paths for Glyphicons were pointing to BS 2.3 png files that are no longer actual #810

Closed gemyago closed 9 years ago

gemyago commented 9 years ago

Attached is a pull request with those paths fixed. Corresponding static assets rebuilt.

gemyago commented 9 years ago

Branch name is mistyped a bit, but that should not make a big difference :)

toadkicker commented 9 years ago

Please send PR's to develop as master should represent the current release

gemyago commented 9 years ago

Dear @toadkicker,

I'm sorry but your comment is not clear to me. Could you clarify what should I do with the PR? Just to make it clear: currently there is a bug that icon font files can not be resolved because they point to wrong locations. This pull request fixes it.

toadkicker commented 9 years ago

The change is fine, just set the pull request so it merges to develop and not master. Or you can use railsstrap, which is fixed already.

gemyago commented 9 years ago

Thanks for your explanation. I've sent the pull request to the develop branch. Hope it's done right now :)