search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 998 forks source link

bootstrap_flash not working on Rails 4.1 #823

Closed mvz closed 9 years ago

mvz commented 9 years ago

On Rails 4.1, bootstrap_flash does not produce any output. This seems to be due to the fact that that flash's keys are now strings instead of symbols.

I'll try to add some more details and perhaps a pull request later.

toadkicker commented 9 years ago

Check out teststrap as well, as I know that flash messages are working there. I'm using railsstrap in it though, and I did do some upgrades to the flash helper there. See https://github.com/toadkicker/railsstrap.

raldred commented 9 years ago

What exactly isn't working? It's mostly fine for me, I'm using Ruby 2.1.5 & Rails 4.1.8

I'm setting flash via either... flash[:notice] = "Here's something you should know" or redirect_to root_path, alert: "Ohh no you don't"

mvz commented 9 years ago

Ah, it seems this is because the project in question is using twitter-bootstrap-rails 2.2.8. This problem was fixed in master in 1e6adfe799b01a95411e09771d07f3b8537093b1. Sorry for the noise.