search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 999 forks source link

fix for options passed to menu_item #852

Closed victorsosa closed 9 years ago

victorsosa commented 9 years ago

Hi,

I just fixed these bugs and clear the rspec results. rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:100 # NavbarHelper menu_item should return a link within an li tag rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:104 # NavbarHelper menu_item should return the link with class 'active' if on current page rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:108 # NavbarHelper menu_item should pass any other options through to the link_to method rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:112 # NavbarHelper menu_item should pass a block but no name if a block is present rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:116 # NavbarHelper menu_item should work with just a block rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:120 # NavbarHelper menu_item should return the link with class 'active' if on current page with a block

Thanks,

victorsosa commented 9 years ago

It's mergeable it's just the ci failed