seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 999 forks source link

Fixed paths of fontawesome to use the ones declared in bootstrap_overrides.less #872

Closed panmari closed 8 years ago

panmari commented 8 years ago

Basically, I added bach the changes from https://github.com/seyhunak/twitter-bootstrap-rails/blob/8d2a6780bde0b5c7285a3198d051530526eb6ad4/vendor/toolkit/fontawesome/path.less which got lost again in an update of fontawesome. This also most probably fixes #866 and #833 in a more gem-compatible way.

panmari commented 8 years ago

Also related: #859

HappyEmu commented 8 years ago

:+1: Would like to see this fixed as well.

disasmwinnie commented 8 years ago

+1 Pls merge.

And maybe thinking of an process not to loose previous commits. As I see in the github issues here and in my app, stuff which was fixed previously breaks again in new updates, repeatedly.