seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.49k stars 996 forks source link

breadcrumbs-on-rails compatibility for this gem #881

Closed fabn closed 8 years ago

fabn commented 9 years ago

Using breadcrumbs-on-rails with this project is currently not possible. With this patch you will retain backward compatibility and also allow breadcrumbs-on-rails users to keep their code working.

This gem breadcrumb implementation is not fully compatibile and does not allow all features of breadcrumbs-on-rails so this patch might be very useful.

If breadcrumbs-on-rails is not present in Gemfile nothing will change for existing users.

seyhunak commented 8 years ago

@fabn did you getting conficts after opening pull request?

fabn commented 8 years ago

No, I didn't. I can rebase the PR and push it again.

fabn commented 8 years ago

@seyhunak rebased and pushed

fabn commented 8 years ago

Thanks.