search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 1k forks source link

added the "show" button on index page for themed resources. #904

Closed abdurrehmanamjad closed 8 years ago

abdurrehmanamjad commented 8 years ago

Hi, In normal rails scaffolding we have three action buttons on index page, which are show, edit, destroy. In twitter bootstrap gem we only had edit and destroy, so whenever I themed any of my resource, the show button disappears because in generators show button is not added. I have added just 3 lines for that specific show button, so that the scaffold resource can be themed as per rails scaffolding standard buttons. I hope this will help the developers. Kind regards, Hafiz Abdur Rehman

abdurrehmanamjad commented 8 years ago

@seyhunak , the error is due to the installation of gem twitter-bootstrap-rails(3.2.2) in ruby 1.9.3 with rails 4.2.6. It is present in many past pull requests. Probably due to some version compatibility.

Error Log: NoMethodError: undefined method spec' for nil:NilClass Installing rails 4.2.6 An error occurred while installing twitter-bootstrap-rails (3.2.2), and Bundler cannot continue. Make sure thatgem install twitter-bootstrap-rails -v '3.2.2'` succeeds before bundling.

abdurrehmanamjad commented 8 years ago

@seyhunak can you please accept that?

seyhunak commented 8 years ago

@abdurrehmanamjad ok but CI failing, can you please check?

seyhunak commented 8 years ago

Accepted, thanks!