search

seyhunak / twitter-bootstrap-rails

Twitter Bootstrap for Rails 6.0, Rails 5 - Rails 4.x Asset Pipeline
https://github.com/seyhunak/twitter-bootstrap-rails
4.5k stars 1k forks source link

Problem with DEPRECATED warnings for Rails 4 #939

Closed abitrolly closed 3 years ago

abitrolly commented 4 years ago

Describe the bug

The warning below is issued every time a Rail 4 project is built.

DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
       Please register a mime type using `register_mime_type` then
       use `register_compressor` or `register_transformer`.

The error for Rails 5 is fixed by https://github.com/seyhunak/twitter-bootstrap-rails/commit/553e785cbfbfba99443b63ae1fcd8882d2c8eef1 which is in master, but not released.

Is would be very nice if a backport of 3.x version of twitter-bootstrap-rails could be released with this bugfix. Because 4.x is not compatible with Rails 4.

https://github.com/seyhunak/twitter-bootstrap-rails/blob/a9a5b41735cdb37e0dcb878eb25dcdf6174412cd/twitter-bootstrap-rails.gemspec#L22

abitrolly commented 3 years ago

Fixed by upgrading less-rails from ~> 2.7.0 to ~> 4.0.0.

seyhunak commented 3 years ago

Can you make a PR @abitrolly if it is possible?

abitrolly commented 3 years ago

@seyhunak done above.