search

seyyed / scalaris

Automatically exported from code.google.com/p/scalaris
Apache License 2.0
0 stars 0 forks source link

io:format/1,2 harming client nodes #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
All relevant/debug io:format/1,2 should be replaced by the log4erl log 
handler. This can potentially harm a RPC client node connected to a Scalaris 
node.

E.g. in rdht_tx.erl:

@/src/transactions/rdht_tx.erl:212
---    io:format("No result for commit received!~n"),
+++    log:log(warn, "No result for commit received!~n"),

Here is a list of only relevant/debug occurrences:

/src/paxos/acceptor.erl:95
/src/paxos/proposer.erl:129,130
/src/paxos/learner.erl:79
/src/paxos/proposer_state.erl:102
/src/transactions/tx_tm_rtm.erl:317,333
/src/comm_layer/comm_port.erl:165
/src/transstore/tmanager.erl:74
/src/transstore/transaction.erl:217,354

Original issue reported on code.google.com by Uwe.Daue...@gmail.com on 25 May 2010 at 7:19

GoogleCodeExporter commented 8 years ago 
When and how is what harmed by the io:formats??

Original comment by schin...@gmail.com on 25 May 2010 at 12:09

GoogleCodeExporter commented 8 years ago 
When I do an RPC call, the io:format result is delivered on my client. This is 
adding 
the text to its log and later when parsing, I have errors due to unexpected 
input 
text.
I can/will work around that, but I thought it is maybe also good to let you 
guys know.

Original comment by Uwe.Daue...@gmail.com on 25 May 2010 at 12:40

GoogleCodeExporter commented 8 years ago 
What kind of RPC call do you do? Via Java? JSON? ???

Original comment by schin...@gmail.com on 25 May 2010 at 1:27

GoogleCodeExporter commented 8 years ago 
RPC running from an Erlang client node to an Erlang Scalaris node; both in 
seperate 
VMs and different machines.

Original comment by Uwe.Daue...@gmail.com on 25 May 2010 at 1:35

GoogleCodeExporter commented 8 years ago 
addressed in r855.

Original comment by schin...@gmail.com on 7 Jul 2010 at 12:40