Fix E9x effect bug that would cause it to always retrigger on tick 1.

sezero / mikmod

Mikmod Sound System (mirror of git repo at https://sf.net/projects/mikmod/)

http://mikmod.sourceforge.net/

72 stars 22 forks source link

Fix E9x effect bug that would cause it to always retrigger on tick 1. #22

Closed AliceLR closed 3 years ago

AliceLR commented 3 years ago

This patch fixes the overtly wrong behavior of the .MOD E9x retrigger effect and attempts to at least establish a sensible default behavior in the spirit of what the original code here was supposed to do. As mentioned by @sagamusix in #21 this probably will need to be followed up with careful inspection/correction for individual formats and .MOD variants (I commented a list of different affected formats also in that issue).

sezero commented 3 years ago

Merged. I hope that this doesn't open a can of worms :)

AliceLR commented 3 years ago

I can't imagine this made anything worse off than it was before... :(

sezero commented 3 years ago

OK :)