search

sezero / mikmod

Mikmod Sound System (mirror of git repo at https://sf.net/projects/mikmod/)
http://mikmod.sourceforge.net/
69 stars 21 forks source link

Checks for extra "no loop" marker #34

Closed neumatho closed 3 years ago

neumatho commented 3 years ago

In the module "Lost in Germary" by GMaxx (can be found on Modland) have another marker for the samples to indicate that they do not loop. Normal marker is 0x000fffff, but in this module, the marker is 0x00f0ffff. Therefore I have added this extra check.

neumatho commented 3 years ago

Attached the module.

Lost In Germany.zip

sezero commented 3 years ago

Can we change the check to if (sample.loopend>=0xfffff) sample.loopend=0; which is what libxmp does?

neumatho commented 3 years ago

Just tested it with your suggesion and that's working fine as well.

AliceLR commented 3 years ago

I'm not particularly familiar with MOD player behavior with loopend values >0xFFFFF but this behavior seems like a reasonable default to me.

neumatho commented 3 years ago

Should this fix be included or are you still consider it?

sezero commented 3 years ago

Should this fix be included or are you still consider it?

I will apply soon, along with some other patches.