Some small fixes for ScreamTracker 2

neumatho commented 3 years ago

One extra position was always added, which made the player to play the first pattern at the end.
Fixed sample loop and detection for invalid values, e.g. N.S. Beat.stm and Batman.stm.

stm_mods.zip

sezero commented 3 years ago

@AliceLR: can you please review?

AliceLR commented 2 years ago

My initial impressions:

The first fix is OK. It partially fixes #9, which is good. I can submit the rest as a separate patch.
The second fix looks OK at a glance. I checked libxmp and it has the same behavior as MikMod without this patch, so I'll confirm and then go ahead and merge this (and submit a patch to libxmp if needed).

edit: the affected sample in N.S. Beat.stm seems to play correctly in both MikMod and libxmp despite a loop being loaded when it shouldn't be. The patch here is still OK. Interestingly, Scream Tracker 2.3 does play the affected sample with a loop (for both PC speaker and SoundBlaster) and it sounds horrible.

AliceLR commented 2 years ago

I'm going to go ahead and merge this.

sezero / mikmod

Some small fixes for ScreamTracker 2 #38