sezero / mikmod

Mikmod Sound System (mirror of git repo at https://sf.net/projects/mikmod/)
http://mikmod.sourceforge.net/
69 stars 21 forks source link

Web Audio wrapper/example #54

Closed carlosrafaelgn closed 3 years ago

carlosrafaelgn commented 3 years ago

Hi everyone!

Just as discussed at #52, I am creating a pull request with the web audio port of libmikmod.

Nothing outside libmikmod/webaudio folder has been changed 😊

sezero commented 3 years ago

Thanks.

Questions:

carlosrafaelgn commented 3 years ago

Hi, @sezero !

Indeed, libmikmodclib.wasm is a prebuilt binary, just as libmikmodprocessor.min.js.

I added these two prebuilt files, along with a third JS file, to the "dist" folder, because that is what most web libraries/frameworks do on GitHub, allowing other developers to quickly download the library to be used in their projects.

But I see your point (future maintenance)... I could just add the "dist" folder to a .gitignore file.

Otherwise, it would be necessary to run these two build scripts (in this order) every time the C files changed:

Should I gitignore the dist folder and push the repo again?

sezero commented 3 years ago

Yes please!

carlosrafaelgn commented 3 years ago

Done!

sezero commented 3 years ago

Thanks, applied.