Xm effect L - Githubissues

sezero / mikmod

Mikmod Sound System (mirror of git repo at https://sf.net/projects/mikmod/)

http://mikmod.sourceforge.net/

69 stars 21 forks source link

Xm effect L #56

Closed neumatho closed 2 years ago

neumatho commented 2 years ago

Created a pull request for issue #48, so the XM effect L to behave correctly.

sezero commented 2 years ago

Alice: please have a look.

sezero commented 2 years ago

Rebased properly.

AliceLR commented 2 years ago

At a glance this looks correct. I'll locate some XM modules that rely on Lxx to test and report back.

AliceLR commented 2 years ago

I made a test module that uses Lxx to create a volume effect with an envelope with exponentially spaced points. As expected, the old behavior is extremely buggy (reads out-of-bounds envelope points) and the new behavior is indistinguishable from FastTracker 2, OpenMPT, libxmp, etc. villgust.xm.zip

Still need to locate actual modules with substantial examples of this effect, which will take a while. : |

AliceLR commented 2 years ago

I was able to find a small handful of modules noticeably affected by this issue (before I got tired of searching). I also found some other XM playback bugs I need to diagnose. The following modules have playback issues that (I think) are fixed by the patch:

A-Move/coop-Lamb/ebony owl netsuke.xm
Cosmic Eclipse/sea of tranquility.xm
Dune/asia mist garden.xm
Graff/ant attack.xm

The last one is the most noticeable by far. I think when the issues I've commented on are addressed this can be merged.

AliceLR commented 2 years ago

This looks OK to me. Merging.