Mod plugin packed - Githubissues

sezero / mikmod

Mikmod Sound System (mirror of git repo at https://sf.net/projects/mikmod/)

http://mikmod.sourceforge.net/

69 stars 21 forks source link

Mod plugin packed #57

Closed neumatho closed 2 years ago

neumatho commented 2 years ago

Added support for depacking ADPCM4 samples used in MOD Plugin.

Note that MOD Plugin also can pack samples in S3M, IT and MOD files, but I do not have any of such modules, so only support in XM files has been added.

You can get a lot of modules at modland here: https://modland.com/incoming/workshop/Modpluginpacked/

sezero commented 2 years ago

@AliceLR: is this good?

sezero commented 2 years ago

Rebased properly.

AliceLR commented 2 years ago

The implementation of this decoder looks consistent with libxmp's ADPCM4 decoder. I will find an ADPCM4 XM and verify. (Don't worry about MOD, S3M, and IT, I can follow up re: those in another patch.)

edit: also, I think the public API change is minor enough that it should be fine. edit 2: MRHPx-HBTN LUCiFER.xm from libxmp's regression tests sounds much better with this patch, so I think it's OK as far as I'm concerned.