search

sezero / quakespasm

QuakeSpasm -- A modern, cross-platform Quake game engine based on FitzQuake.
https://sourceforge.net/projects/quakespasm/
GNU General Public License v2.0
244 stars 97 forks source link

Allow any supported music type to play #113

Closed jjelliott closed 1 month ago

jjelliott commented 1 month ago

Removes the restriction on CDRIP_TYPES for music. This unnecessary restriction makes the tracker formats supported by the engine (umx, mod, it, etc.) useless as they cannot be used for map music.

Removed the defines as well, as they were not used anywhere else.

sezero commented 1 month ago

@ericwa, @andrei-drexler: what do you think?

jjelliott commented 1 month ago

@sezero requested modification made

andrei-drexler commented 1 month ago

@ericwa, @andrei-drexler: what do you think?

Personally, I think tracker music is a bit anachronistic for Quake, but it's a feature that's been requested previously for IW, and since the libraries already support these formats and the engine changes are minimal, I guess it makes sense to add this and make some modders happy.

sezero commented 1 month ago

OK, patch is in. Thanks.