search

sezero / quakespasm

QuakeSpasm -- A modern, cross-platform Quake game engine based on FitzQuake.
https://sourceforge.net/projects/quakespasm/
GNU General Public License v2.0
227 stars 96 forks source link

Packet Overflows #59

Closed Flecked42 closed 1 year ago

Flecked42 commented 1 year ago

Packet Overflows can happen in the end fight on map https://www.slipseer.com/index.php?resources/i-no-longer-fear-the-ranger-guarding-my-heel.222/

Here's a test save, just go crazy gibing everything and you'll get packet overflows. Type quad in the console to give yourself quad for easy testing.

end.zip

This doesn't happen in Ironwail. It doesn't happen in vkQuake either, but vkQuake uses FTE999 protocol.

Flecked42 commented 1 year ago

Someone mentioned MAX_DATAGRAM could be the issue https://github.com/sezero/quakespasm/blob/9ccd014763d1b29413cc2e0dfdae0bc466d3fe85/Quake/quakedef.h#L84

Ironwail increased it to 64000

sezero commented 1 year ago

Someone mentioned MAX_DATAGRAM could be the issue Ironwail increased it to 64000

@andrei-drexler, @ericwa: can there be any subtle issues by blindly increasing this?

sezero commented 1 year ago

Joequake recently bumped MAX_DATAGRAM to 64000 https://github.com/j0zzz/JoeQuake/commit/4fcec0071f292595f260e78ccaddb52909d5932d

@ericwa, @Shpoike: can there be any subtle issues by blindly increasing this?

sezero commented 1 year ago

MAX_DATAGRAM rasid to 64000 in git. Closing as fixed.