search

sezna / nps

NPM Package Scripts -- All the benefits of npm scripts without the cost of a bloated package.json and limits of json
MIT License
1.43k stars 93 forks source link

Fixes a bug in PR#181 and adds a test. #183

Closed Hypercubed closed 6 years ago

Hypercubed commented 6 years ago

Sorry for the bad PR, this fixes the bug I introduced and adds a test. Still not getting 100% coverage, unfortunately.

Hypercubed commented 6 years ago

I tried to get 100% coverage but I'm not familiar with the mocking setup.

kentcdodds commented 6 years ago

I'm fine if you want to add an /* istanbul ignore next */ comment where the coverage issue is.

Hypercubed commented 6 years ago

Will do...

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e52b136). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?    386           
  Branches          ?     93           
=======================================
  Hits              ?    386           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/bin-utils/initialize/index.js 100% <ø> (ø)
src/bin-utils/parser.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e52b136...e727bf9. Read the comment docs.