sezna / nps

NPM Package Scripts -- All the benefits of npm scripts without the cost of a bloated package.json and limits of json

MIT License

1.43k stars 93 forks source link

Fix logging and silent #195

Closed kevjin closed 5 years ago

kevjin commented 5 years ago

What: This PR resolves #141 . Fixes configurable options for logging levels and silent.

Why: CLI default log level and silent options ('info' and false) override custom options configured in package-scripts.

How: Swap the order in which lodash merges default and config options.

Checklist:

[ ] Documentation N/A
[ X] Tests
[X ] Ready to be merged
[X ] Added myself to contributors table

codecov[bot] commented 5 years ago

Codecov Report

Merging #195 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #195   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         389    389           
  Branches       94     94           
=====================================
  Hits          389    389

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5d3b73...734310a. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #195 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #195   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         389    389           
  Branches       94     94           
=====================================
  Hits          389    389

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5d3b73...734310a. Read the comment docs.

kentcdodds commented 5 years ago

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

kevjin commented 5 years ago

Thanks Kent, and appreciate the quick review!