sezna / nps

NPM Package Scripts -- All the benefits of npm scripts without the cost of a bloated package.json and limits of json
MIT License
1.43k stars 93 forks source link

Fix ci deploys #204

Closed Ameobea closed 5 years ago

Ameobea commented 5 years ago

What: Fix CI deploys by disabling stash of all untracked files

Why: CI deploys were broken, creating invalid versions that failed to install for users

How:

Checklist:

codecov[bot] commented 5 years ago

Codecov Report

Merging #204 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #204   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         397    396    -1     
  Branches       96     96           
=====================================
- Hits          397    396    -1
Impacted Files Coverage Δ
src/get-logger.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecb5c43...ac2204c. Read the comment docs.

sezna commented 5 years ago

I went ahead and tacked on:

deploy:
  on:
    tags: true

to your change. That way it will only deploy on tagged releases. I could have sworn it was already enabled but apparently we are deploying on every branch.

I also got rid of the link that was linking to the docs in the release to fix #203