sezna / nps

NPM Package Scripts -- All the benefits of npm scripts without the cost of a bloated package.json and limits of json
MIT License
1.43k stars 93 forks source link

feat: forward cli args #233

Open OBannon37 opened 2 years ago

OBannon37 commented 2 years ago

What: Follows the format specified in #139 to forward command line arguments to scripts. Notably, this disables running scripts in parallel from the command line.

Why: See discussion in #139

How: By changing the parsing of command line args in src/bin/nps.js.

Checklist:

I'd like to confirm the approach here. Specifically, I'm not sure if we should also be considering programatic use here. I thought no: I left the implementation of runPackageScript as is, so folks can still run scripts in parallel from the function call if they'd like to. I am assuming if someone is calling that function, they can already pass arbitrary command line args to each command just with string concatenation after a space, which is not possible from the CLI using the previous yargs parsing.

This would be a breaking change if released.

If the approach looks good, I can add documentation.