benlabbe
commented
6 years ago Hello,
Thank you for answering me. You should have a look to the following commits I made in my branch. They made me the use of elasticlient much simpler as an external library in my own project, and here I mean includind and linking to the lib through cmake packages.
You might merge these commits also, if these functionalities are useful in your context. Tell me if you prefer a merge request from me instead of merging on your own.
With regards
Benjamin
Le mar. 22 mai 2018 à 10:59, Martin Bumba notifications@github.com a écrit :
Hello @benlabbe https://github.com/benlabbe, thank you for your participation on Elasticlient library. At first, I would like to say sorry for my late reply. Few minutes ago I merged the fix (5d91a85 https://github.com/seznam/elasticlient/commit/5d91a855f058c61257ad0b4034e380c674cde2e7) which should ensure that JSON content type is sent when request's body is not empty. I also modified tests for this issue.
Does this solve the issue for you? This pull request goes from your master branch, so I'm not entirely sure which commits are relevant. Thank you
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seznam/elasticlient/pull/1#issuecomment-390916018, or mute the thread https://github.com/notifications/unsubscribe-auth/AkVeGhePVRVILGgy8VwPtBsp38VS-g2Iks5t09N7gaJpZM4TIMHG .
Hello @benlabbe, thank you for your participation on Elasticlient library. At first, I would like to say sorry for my late reply. Few minutes ago I merged the fix (https://github.com/seznam/elasticlient/commit/5d91a855f058c61257ad0b4034e380c674cde2e7) which should ensure that JSON content type is sent when request's body is not empty. I also modified tests for this issue.
Does this solve the issue for you? This pull request goes from your master branch, so I'm not entirely sure which commits are relevant. Thank you